search

jags111 / efficiency-nodes-comfyui

A collection of ComfyUI custom nodes.- Awesome smart way to work with nodes!
https://civitai.com/models/32342
GNU General Public License v3.0
1k stars 98 forks source link

Efficient Loader no clip skip #216

Open gottfriedm opened 4 months ago

gottfriedm commented 4 months ago

It seems it is not possible to reproduce results obtained without clip skip (using standard nodes), since the maximum value for clip skip on the Efficient Loader node is -1.

Is it possible to use Efficient Loader with no clip skip?

woferry commented 4 months ago

It would be nice if it allowed 0 as a way to turn it off, IMO. Same would go for the other Efficiency nodes that use it, like XY Input: Checkpoint.

gottfriedm commented 4 months ago

Yes, that would be much appreciated.

I hacked the scripts to allow for clip_skip 0 on the checkpoint loader node, and found another behavior: On a fresh start of comfy, setting clip skip 0 works as expected. If i change it to -1 (or some other negative value) i obviously get a different result. But if i then change it back to 0, i don't get the initial result, instead i get the same result as with -1. I have to restart comfy to get the correct result for clip_skip 0.

It could be a problem of me hacking the script to allow 0, but i suspect there's something else going on with the caching.