jags111 / efficiency-nodes-comfyui

A collection of ComfyUI custom nodes.- Awesome smart way to work with nodes!
https://civitai.com/models/32342
GNU General Public License v3.0
1k stars 98 forks source link

Can the xyz graph function support the use of flux's lora? #235

Open KILOY00 opened 2 months ago

KILOY00 commented 2 months ago

I updated to the latest version efficiency-nodes-comfyui, but because flux in comfyui uses different nodes, I cannot use the xyz function. I would like to ask if it can be supported?

theIroaia commented 2 months ago

I think for Flux, it might be ideally to have a new efficient loader node that could take in unet model, clips and vae, then packs them to be the dependencies input needed for a Lora XY plot, since there are different types of model loading handling like GGUF quant for flux. But if I read the code correctly, the load_model handling inside the XY plot might also need to adapt to work with this type of loaded model.

It would be quite useful for Lora training steps comparison and especially Lora block effects analysis, since Inspire pack seems to be the only Lora block handling tool that’s working for Flux.

defertoexpertise commented 2 months ago

Was just coming to check if a GGUF quant version for loader exists as other than that not sure how to do a xy plot for loras for instance