jags111 / efficiency-nodes-comfyui

A collection of ComfyUI custom nodes.- Awesome smart way to work with nodes!
https://civitai.com/models/32342
GNU General Public License v3.0
1k stars 98 forks source link

HiRes-Fix issue - Required input is missing: control_net_name #237

Open AlexanderKhudoev opened 2 months ago

AlexanderKhudoev commented 2 months ago

So, I place the default node "HiRes-Fix Script" connected to KSampler (Efficient). And after "Queue Prompt" clickedm it shows the error

HighRes-Fix Script:
- Required input is missing: control_net_name
- Value -1 smaller than min of 0: seed

I don't use any "Control Net" in my config. How to fix it?

image

LPCTSTR commented 2 months ago

Value -1 smaller than min of 0: seed

same with this error.

Update: The issue was resolved after disabling use_same_seed.

BellZwei commented 2 months ago

Any solution for "Required input is missing: control_net_name"

Arnaud3013 commented 1 month ago

a simple fix: in file efficiency_nodes.py, line 4062, replace: "use_controlnet": use_controlnet_widget, by "use_controlnet": ("BOOLEAN", {"default": False}), image

And for seed, do not use "same seed", set your own, or make seed an input, create a primitive (from utils) and use that primitive as seed for your sampler and high-res fix image

TheOrganicRobot commented 1 week ago

a simple fix: in file efficiency_nodes.py, line 4062, replace: "use_controlnet": use_controlnet_widget, by "use_controlnet": ("BOOLEAN", {"default": False}), image

This produces a separate error for me

image

Arnaud3013 commented 1 week ago

Hmm maybe change line control_net_name too by the one i have in my screenshot. Tell me if it help

TheOrganicRobot commented 1 week ago

Same issue. Your screenshot has "control_net_name": (["None"] + folder_paths.get_filename_list("controlnet"),), listed on line 4063, but the default install doesn't. Changing this doesn't fix it.

I don't have anything controlnet installed currently.

TheOrganicRobot commented 1 week ago

Installing the controlnet_aux mentioned on line 4017 adds an additional error

image

Arnaud3013 commented 1 week ago

Have you restart all the project? (close and reopen comfy) or try remove and add in workflow the efficiency high res fix node. Because changing use_controlnet should prevent any loading frop controlnet_name I'm not in front of my computer, i can't check more at the moment. I'll try send my file. I havn't change line 4017 on my side

TheOrganicRobot commented 1 week ago

After multiple tests, it appears changing: "control_net_name": (folder_paths.get_filename_list("controlnet"),),

to: "control_net_name": (["None"] + folder_paths.get_filename_list("controlnet"),),

was what fixed the issue.

That, and I was using an SDXL checkpoint but not the SDXL Loader and Sampler and it was just producing images of noise once that was working. Changing line 4062 made no difference (as you were just replacing the variable with the direct value it referenced.)

Thanks for the assist!

Arnaud3013 commented 1 week ago

Glad it work. Good generations!

LuisMasters10 commented 1 week ago

After multiple tests, it appears changing: "control_net_name": (folder_paths.get_filename_list("controlnet"),),

to: "control_net_name": (["None"] + folder_paths.get_filename_list("controlnet"),),

was what fixed the issue.

That, and I was using an SDXL checkpoint but not the SDXL Loader and Sampler and it was just producing images of noise once that was working. Changing line 4062 made no difference (as you were just replacing the variable with the direct value it referenced.)

Thanks for the assist!

HEY I did what you did but I am still having the same issue with the [ ] thing, I wonder what it is?