search

jagt / clumsy

clumsy makes your network condition on Windows significantly worse, but in a controlled and interactive manner.
http://jagt.github.io/clumsy/
Other
5.27k stars 521 forks source link

Upgrade to the latest WinDivert #11

Closed basil00 closed 10 years ago

basil00 commented 10 years ago

Hi jagt,

The current version of clumsy is using a very old version of WinDivert, namely WinDivert1.1.1 for the latest 0.2-rc release. WinDivert1.1.1 contains bugs that may affect clumsy, e.g. see here.

I recommend upgrading to the latest version of WinDivert (currently WinDivert1.1.6), and then to WinDivert1.1.7 when it is released (hopefully released 1-2weeks).

jagt commented 10 years ago

Hi basil. Again thanks for your great work on WinDivert. I happened to get myself some free time a few weeks later, and I'll upgrade the dependency to 1.1.7 as soon as it's released. Thanks for the heads up.

basil00 commented 10 years ago

FYI, WinDivert 1.1.7 has been released.

Note that the file structure has changed. There is no more co-installer files, no more WinDivert.inf, and and driver filename now depends on the underlying architecture (WinDivert64.sys vs. WinDivert32.sys). See the docs for more detailed information. Apart from that I think upgrading should be straightforward.

Also, I think issues #4 and #5 may be related to the old buggy version of WinDivert. Version 1.1.1 will drop some TCP packets even when it is not supposed to, which can slow down a connection.

jagt commented 10 years ago

Great news! I'll start working on it soon. Will keep you posted!

jagt commented 10 years ago

Hi Basil, I've just updated WinDivert to 1.1.7 and uploaded a new release. It did work very straight forward. Seems overlapping IO is added now I'll try to see if I can switch to it later. Thanks!

basil00 commented 10 years ago

New version looks good. Overlapped I/O can offer a small performance boost, but clumsy should be OK without it.

jagt commented 10 years ago

@basil00 Thanks!