jahaziel17 / wro4j

Automatically exported from code.google.com/p/wro4j
0 stars 0 forks source link

ResourceProxyRequestHandler accept method failing to match in v1.7.3, results in 404s #840

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
The format of the URLs generated by wro4j's CSS URL rewriting changed in 1.7.3, 
as did the ResourceProxyRequestHandler accept method for matching them.

example:

.../wro/wroAPI/wroResources?id=classpath:META-INF/resources/webjars/bootstrap/2.
3.2/img/glyphicons-halflings.png

In line 73 of ResourceProxyRequestHandler.java, the accept method passes 
request.getRequestURI() to the isProxyUri method, which checks if the given URL 
contains "wroAPI/wroResources?id=".

However, request.getRequestURI() does not contain the query parameters (i.e. 
"?id="), so this check always fails to match.

http://docs.oracle.com/javaee/6/api/javax/servlet/http/HttpServletRequest.html#g
etRequestURI()

Original issue reported on code.google.com by fpjonso...@gmail.com on 3 Feb 2014 at 10:02

GoogleCodeExporter commented 8 years ago

Original comment by alex.obj...@gmail.com on 4 Feb 2014 at 8:26

GoogleCodeExporter commented 8 years ago
Fixed in branch 1.7.x

Original comment by alex.obj...@gmail.com on 20 Feb 2014 at 4:52