search

jaheyns / CfdOF

Computational Fluid Dynamics (CFD) for FreeCAD based on OpenFOAM solver
GNU Lesser General Public License v3.0
449 stars 85 forks source link

Add Langtry and Menters 4 eqn K Omega SST with transistion - [merged] #105

Closed oliveroxtoby closed 1 year ago

oliveroxtoby commented 1 year ago

In GitLab by @icojb25 on Mar 27, 2022, 09:32

Merges feature/add-langtrys-SST-transition-model -> master

Updated CfdOF with functionality for Langtry and Menter's 4 equation k Omega SST model.

oliveroxtoby commented 1 year ago

In GitLab by @icojb25 on Mar 27, 2022, 09:32

requested review from @oliveroxtoby

oliveroxtoby commented 1 year ago

In GitLab by @oliveroxtoby on Mar 28, 2022, 07:09

Commented on data/defaults/0/ReThetat line 5

This looks nice. My only comment is that for these files that are turbulence-model specific, we only include the content for those turb models where they are used, so for this one:

%{%(physics/Turbulence%)
%:RANS
%{%(physics/TurbulenceModel%)
%:kOmegaSSTLM
%[_header%]
...(rest of content)
%}
%}

If the file ends up blank (as it will for models other than k-omega SST LM here) the file is not created by the template builder and prevents pollution of the 0 directory with a bunch of unused files.

oliveroxtoby commented 1 year ago

In GitLab by @icojb25 on Mar 28, 2022, 07:14

Commented on data/defaults/0/ReThetat line 5

ah, shucks, thanks @oliveroxtoby , yeah I missed that and had an issue with the extra fields being included in 0/ directory, so had a workaround for that. I thought initially it was an oversight in the TemplateBuilder due to only one model previously being available. I will update. :thumbsup: Thanks for that.

oliveroxtoby commented 1 year ago

In GitLab by @icojb25 on Mar 28, 2022, 07:16

Commented on data/defaults/0/ReThetat line 5

Ah, i see why i missed it, its not in the original templates, so yeah, will add now that we have addition tmodels

oliveroxtoby commented 1 year ago

In GitLab by @icojb25 on Mar 28, 2022, 07:19

added 1 commit

Compare with previous version

oliveroxtoby commented 1 year ago

In GitLab by @icojb25 on Mar 28, 2022, 07:31

added 2 commits

Compare with previous version

oliveroxtoby commented 1 year ago

In GitLab by @icojb25 on Mar 28, 2022, 07:32

marked this merge request as ready

oliveroxtoby commented 1 year ago

In GitLab by @oliveroxtoby on Mar 28, 2022, 07:53

Commented on data/defaults/0/ReThetat line 3

@icojb25 There ought to be an extra %} needed at the end of the file with this change (quite possible that the template builder is failing to notice and working anyway though! :-|)

oliveroxtoby commented 1 year ago

In GitLab by @oliveroxtoby on Mar 28, 2022, 07:53

approved this merge request

oliveroxtoby commented 1 year ago

In GitLab by @icojb25 on Mar 28, 2022, 08:03

added 1 commit

Compare with previous version

oliveroxtoby commented 1 year ago

In GitLab by @icojb25 on Mar 28, 2022, 08:58

added 1 commit

Compare with previous version

oliveroxtoby commented 1 year ago

In GitLab by @icojb25 on Mar 28, 2022, 09:03

added 15 commits

Compare with previous version