search

jaheyns / CfdOF

Computational Fluid Dynamics (CFD) for FreeCAD based on OpenFOAM solver
GNU Lesser General Public License v3.0
442 stars 84 forks source link

Feature/add srf option #132

Closed oliveroxtoby closed 1 year ago

oliveroxtoby commented 1 year ago

In GitLab by @icojb25 on May 6, 2022, 09:02

Merges feature/add-srf-option -> develop

First impl of SRFSimpleFoam and cyclic BC's. @oliveroxtoby I've not included SRFVelocity as an inlet velocity option yet - perhaps we can have some discussion on this - I'm not sure if this is essential at this point (I dont think it is, unless a user wants to do velocity inlets in the rotating frame - i think fixedValue is still valid). If essential, perhaps we can have some discussion on where / how we'd like to implement.

oliveroxtoby commented 1 year ago

In GitLab by @icojb25 on May 6, 2022, 09:02

requested review from @oliveroxtoby

oliveroxtoby commented 1 year ago

In GitLab by @icojb25 on May 8, 2022, 03:12

added 3 commits

Compare with previous version

oliveroxtoby commented 1 year ago

In GitLab by @icojb25 on May 8, 2022, 03:26

added 1 commit

Compare with previous version

oliveroxtoby commented 1 year ago

In GitLab by @icojb25 on May 8, 2022, 05:32

added 1 commit

Compare with previous version

oliveroxtoby commented 1 year ago

In GitLab by @icojb25 on May 8, 2022, 05:34

added 1 commit

Compare with previous version

oliveroxtoby commented 1 year ago

In GitLab by @oliveroxtoby on May 8, 2022, 20:24

Thanks, this looks great. I'm happy with most of it: Just one thing, could I ask that we not have SRF velocity as a separate BC, but rather have the 'Relative to rotating frame' option available on the uniform inlet BC if SRF is active? And case write, the uniform velocity inlet should always be written as SRFVelocity if the case is SRF.

oliveroxtoby commented 1 year ago

In GitLab by @icojb25 on May 9, 2022, 01:06

hi thanks @oliveroxtoby yes, I think thats a good idea and cleaner way to implement. Thanks for that.

oliveroxtoby commented 1 year ago

In GitLab by @icojb25 on May 9, 2022, 09:50

added 1 commit

Compare with previous version

oliveroxtoby commented 1 year ago

In GitLab by @oliveroxtoby on May 11, 2022, 05:53

Cool. Mark as ready when you're happy, and I'll have a scan through the code and merge.

oliveroxtoby commented 1 year ago

In GitLab by @icojb25 on May 11, 2022, 06:10

hey thanks @oliveroxtoby - will do, there's a funny issue with theh BC's code which I havent quite figured out yet. I believe something to do with renaming and / or createPatchDict but effectively we end up with a spurious residual patch in the field boundary definition files. Otherwise I'm happy with the rest of it

oliveroxtoby commented 1 year ago

In GitLab by @icojb25 on May 12, 2022, 01:18

added 25 commits

Compare with previous version

oliveroxtoby commented 1 year ago

In GitLab by @icojb25 on May 13, 2022, 15:58

added 7 commits

Compare with previous version

oliveroxtoby commented 1 year ago

In GitLab by @icojb25 on May 23, 2022, 08:25

added 6 commits

Compare with previous version

oliveroxtoby commented 1 year ago

In GitLab by @icojb25 on May 24, 2022, 23:15

added 1 commit

Compare with previous version

oliveroxtoby commented 1 year ago

In GitLab by @icojb25 on May 28, 2022, 05:12

added 1 commit

Compare with previous version

oliveroxtoby commented 1 year ago

In GitLab by @icojb25 on May 30, 2022, 03:40

added 1 commit

Compare with previous version

oliveroxtoby commented 1 year ago

In GitLab by @icojb25 on May 30, 2022, 13:10

added 1 commit

Compare with previous version

oliveroxtoby commented 1 year ago

In GitLab by @icojb25 on May 31, 2022, 24:48

added 1 commit

Compare with previous version

oliveroxtoby commented 1 year ago

In GitLab by @icojb25 on May 31, 2022, 03:08

added 1 commit

Compare with previous version

oliveroxtoby commented 1 year ago

In GitLab by @icojb25 on Jun 14, 2022, 12:56

added 1 commit

Compare with previous version

oliveroxtoby commented 1 year ago

In GitLab by @icojb25 on Jun 23, 2022, 14:19

added 40 commits

Compare with previous version

oliveroxtoby commented 1 year ago

In GitLab by @icojb25 on Jul 29, 2022, 21:25

added 11 commits

Compare with previous version

oliveroxtoby commented 1 year ago

Merged