Integrate scalar transport - [merged] #134

Closed oliveroxtoby closed 1 year ago

In GitLab by @oliveroxtoby on May 10, 2022, 21:21

Merges integrate-scalarTransport -> develop

Hi Jon Are you ok with these changes to scalar transport?

In GitLab by @oliveroxtoby on May 10, 2022, 21:21

requested review from @icojb25

In GitLab by @icojb25 on May 11, 2022, 24:49

added 1 commit

8d86c9bb - Change scalar field name in template to match filename as well

Compare with previous version

In GitLab by @icojb25 on May 11, 2022, 24:57

Thanks for the fix to the field name.

1) If we are allowing the field name to change (which is cool), we could now allow multiple STF's per simulation as well, so I dont know if we want to remove that restriction now as well

Agreed - I hadn't noticed, but we should do that.

2) If the user is using the multiphase physics, would that not make the phase restriction option valid?

Fair enough, I'll add it back. It would be nice if it was a dropdown of valid phase names like we have in the init fields dialog (for example) rather than free-form text.

3) Since 1), do we want to somehow restrict users from entering field names which would clash with existing fields, like U, p or T? Or is it caveat emptor (!)

Good point. Maybe caveat emptor for now, but it would be good if we had a more formal list we can query of which solvers and turbulence models use which fields. Something like a dictionary with information for each solver name (e.g. whether it uses kinematic or dynamic pressure, which fields it involves, etc.) would make the code cleaner.

I cant see where you're re-writing the file name, but thats pretty cool.

It's this feature of the template builder - also used for giving the alpha fields the correct name: https://gitlab.com/opensimproject/cfdof/-/blob/develop/data/defaults/_Readme.md#L59

In GitLab by @oliveroxtoby on May 11, 2022, 21:07

added 1 commit

615ba22b - Re-enable phase-restricted scalar transport; allow multiple scalarTransport objects

Compare with previous version

In GitLab by @icojb25 on May 12, 2022, 01:13

Nice addition to the workbench @oliveroxtoby :thumbsup:

jaheyns / CfdOF

Integrate scalar transport - [merged] #134