jaheyns / CfdOF

Computational Fluid Dynamics (CFD) for FreeCAD based on OpenFOAM solver
GNU Lesser General Public License v3.0
442 stars 84 forks source link

Add PurgeWrite property to control how many time dirs will be kept - [merged] #140

Closed oliveroxtoby closed 1 year ago

oliveroxtoby commented 1 year ago

In GitLab by @adrianinsaval on Nov 3, 2022, 24:17

Merges purgeWrite -> master

adresses

16

no GUI implemented, this is controlled just in the property panel

oliveroxtoby commented 1 year ago

In GitLab by @adrianinsaval on Nov 3, 2022, 24:19

btw good job with the template stuff, turns out it was pretty easy to add this

oliveroxtoby commented 1 year ago

In GitLab by @oliveroxtoby on Nov 3, 2022, 18:52

Commented on Data/Templates/case/system/controlDict line 40

Was it your intention to hard-code this? Shouldn't we use the set value of PurgeWrite here as well?

oliveroxtoby commented 1 year ago

In GitLab by @oliveroxtoby on Nov 3, 2022, 18:53

Thank you! :-)

oliveroxtoby commented 1 year ago

In GitLab by @adrianinsaval on Nov 3, 2022, 18:59

Commented on Data/Templates/case/system/controlDict line 40

changed this line in version 2 of the diff

oliveroxtoby commented 1 year ago

In GitLab by @adrianinsaval on Nov 3, 2022, 18:59

added 1 commit

Compare with previous version

oliveroxtoby commented 1 year ago

In GitLab by @adrianinsaval on Nov 3, 2022, 19:00

Commented on Data/Templates/case/system/controlDict line 40

my bad! I had hardcoded a value for my use first and it seems I didn't commit the change to use property value, I fixed it now.

oliveroxtoby commented 1 year ago

In GitLab by @oliveroxtoby on Nov 4, 2022, 06:31

approved this merge request

oliveroxtoby commented 1 year ago

In GitLab by @oliveroxtoby on Nov 4, 2022, 06:32

resolved all threads