search

jahilldev / component-elements

Create a custom element from any component with these tiny functions (2KB GZipped, ~1KB Brotli). Preact and React currently supported
MIT License
89 stars 7 forks source link

Support Node 18.x #24

Closed Half-Shot closed 1 year ago

Half-Shot commented 1 year ago

I noticed that the package.json requires Node 16, but 18 has been LTS for a while. This presumably needs testing & updating.

jahilldev commented 1 year ago

Hi @Half-Shot,

Thanks for helping out, yeh so the engines property is currently set to Node >=10, due to us building ES2016 for the distributable. This doesn't mean we don't support versions higher than this, however. Both packages should work just fine on the latest LTS.

Our CI process is still using Node 16 LTS, however, so I'm going to update that later today.

Appreciate the help 👍

jahilldev commented 1 year ago

I've just realised you're referring to the root package.json, which shouldn't have this property, so I've removed 👍

jahilldev commented 1 year ago

Merged, thanks again, @Half-Shot

Half-Shot commented 1 year ago

Thanks!