jahirfiquitiva / Kuper

Free, feature-rich, easily customizable Android dashboard for widgets apps with Zooper widgets and/or Kustom assets (Widgets, Wallpapers and Komponents)
https://dashbud.dev
Other
193 stars 30 forks source link

Kustom API have been updated to 2.0 #78

Closed frmz closed 1 year ago

frmz commented 1 year ago

Kuper Version

2.4.4

Describe the feature

Hello! I see you have forked kustomapi, shouldn't bee needed anymore, took the time to upgrade API libs and deps to a more recent release. You can migrate to kustom api 2.0: https://central.sonatype.com/artifact/org.bitbucket.frankmonza/kustomapi/20

If you find an issue just let me know by opening an incident here: https://bitbucket.org/frankmonza/kustomapi/issues?status=new&status=open

Thanks!

Describe alternatives you have considered

No response

Additional context or info

No response

welcome[bot] commented 1 year ago

Thanks for opening your first issue here :smiley:! Please be sure to follow the issue template and check the contribution guidelines :wink: (otherwise the issue will be ignored :confused:).

jahirfiquitiva commented 1 year ago

interesting @frmz ... thanks for letting me know ... Are there any breaking/critical changes in the update? 😅

frmz commented 1 year ago

interesting @frmz ... thanks for letting me know ... Are there any breaking/critical changes in the update? 😅

Not really, just bumped gradle version, removed legacy android support library, removed Async Task in preset library (in case you use it), minSDK is now 23, everything else is the same

jahirfiquitiva commented 1 year ago

sounds good @frmz .. will look into this soon, thanks! 🙌

jahirfiquitiva commented 1 year ago

@frmz I just realized Kuper uses minSDK 21 ... any chance of setting the minSDK in your library to 21 too?

jahirfiquitiva commented 1 year ago

@frmz also, the latest version is not 2.0 but 20... you probably missed the dot 😅

frmz commented 1 year ago

@frmz also, the latest version is not 2.0 but 20... you probably missed the dot 😅

I indeed missed the dot but i do not want to go back as it would break some IDE that suggests upgrading, so i will just using integer releases from now on, not too bad. I can not set minSDK to 21 as Kustom now requires version 26, basically no one is in API < 26 anyway (its like less than 1%)

jahirfiquitiva commented 1 year ago

@frmz

Have the intents for the Kustom apps changed? If so, which ones are the newest ones?

These are the ones I'm currently using, but I think they're not working as expected

I'm also facing errors like

java.lang.SecurityException: Permission Denial: starting Intent { dat=kfile://dev.jahir.kuper.app.kustom.provider/... cmp=org.kustom.lockscreen/org.kustom.lib.editor.LockAdvancedEditorActivity } from ProcessRecord{2cedf7b 17119:dev.jahir.kuper.app/u0a249} (pid=17119, uid=10249) not exported from uid 10273

This is the intent code

val intent = Intent().apply { setComponent(component) }
try {
    intent.data = Uri.Builder()
        .scheme("kfile")
        .authority("${context.packageName}.kustom.provider")
        .appendPath(path)
        .build()
} catch (e: Exception) {
    intent.data = Uri.parse("kfile://${context.packageName}/$path")
}
return intent
frmz commented 1 year ago

The Lockscreen Editor was not exported, this was a mistake, i have fixed it and uploading a new release. The other apps should work just fine, please ensure you are properly adding the packages to the QUERY section in the manifest, es:

  <queries>
    <package android:name="org.kustom.widget" />
    <package android:name="org.kustom.widget.pro" />
    <package android:name="org.kustom.lockscreen" />
    <package android:name="org.kustom.lockscreen.pro" />
    <package android:name="org.kustom.wallpaper" />
    <package android:name="org.kustom.wallpaper.pro" />
    <package android:name="org.kustom.watchface" />
    <package android:name="org.kustom.watchface.pro" />
  </queries>
jahirfiquitiva commented 1 year ago

@frmz The queries are included. Anyway, opening a widget from Kuper (with the intent previously shared) does not open the widget editor correctly

Is something missing? What could be the reason for it to not work?

frmz commented 1 year ago

@frmz The queries are included. Anyway, opening a widget from Kuper (with the intent previously shared) does not open the widget editor correctly

Can you provide an APK to test that? I will also test this on KWGT ASAP using the standard APK Skin

jahirfiquitiva commented 1 year ago

@frmz I have uploaded a debug and a release apk here https://box.jahir.dev/shared/bbb4d143e1c2c58c

Please let me know how the tests go. Thanks!

jahirfiquitiva commented 1 year ago

@frmz Do you have any updates on this?

frmz commented 1 year ago

This is now fixed in Kustom version >= 3.74b328516 (its available via manual download now, being approved in the play store)