jahirjoy / gitiles

Automatically exported from code.google.com/p/gitiles
0 stars 0 forks source link

gitiles timestamps lack timezone details #51

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
in this page you can see two timestamps:
https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/2b6e4
89fb5bbab066c8dd55167dc40d790c91bab

but there's no information to indicate what timezones those are in.  the 
reasonable thing would be to assume they're localized, but we have way too many 
bad systems at Google that blindly output PST or are otherwise local to the 
system/office.  adding the explicit timezone (or the UTC offset) would make the 
output unambiguous & reliable all the time.  all other git viewers i've used 
include this.

issue 5 covered normalizing the timestamps from various sources to one timezone 
which is fine, but the final timezone should not be stripped.  collapsing them 
in the blame output so as to get more content in the output is easy to do, but 
that's still unrelated to displaying the timestamp in the log output (as quoted 
above).

Original issue reported on code.google.com by vapier@chromium.org on 14 May 2014 at 7:39

GoogleCodeExporter commented 8 years ago
Thanks for explicitly listing the separate concerns here.

I was actually interpreting the primary anti-timezone argument of issue 5 as 
"timezone does not add any information [for Chrome], therefore it should be 
omitted." The "also it's taking up valuable horizontal real estate" argument I 
thought was secondary. I may have been weighting these incorrectly.

I think we can strip the timezone in blame only but not elsewhere. (Though if I 
get pushback from the same people as issue 5 understand that it might not land 
:)

Original comment by dborowitz@google.com on 14 May 2014 at 8:34