search

jahnf / Projecteur

Linux Desktop Application for the Logitech Spotlight device (and similar devices) - Digital Laser Pointer
MIT License
379 stars 33 forks source link

Fixes high CPU usage after device-vibration #135

Closed mayanksuman closed 3 years ago

mayanksuman commented 3 years ago

This commit introduces separate read and write QSocketNotifier for subdevices. Write notifier is required for sending data to HID subdevice. Read notifier for HID subdevice will help in reading data from device like battery percentage and configuring the spotlight device like configuring it to send long press events for Next and previous button (See #71).

This commit also fixes #133 as read notifier for HID subdevice do not send activated signal continuosly after a write operation. Rather the on activated signal, the device is read (However it currently does not do anything with the read value).

Fixes #133

jahnf commented 3 years ago

Thank you. Will do a review in the upcoming week 👍

mayanksuman commented 3 years ago

Hi @jahnf, Thanks for the review. I have implemented all the changes. However during rebasing, I rewrote the history by mistake.

I have made a new pull request (#137 ) with clean history (and all the changes recommended).

I am closing this pull request to avoid any confusion. Please review the new PR #137.