search

jahnf / Projecteur

Linux Desktop Application for the Logitech Spotlight device (and similar devices) - Digital Laser Pointer
MIT License
379 stars 33 forks source link

Minor code fixes #161

Closed mayanksuman closed 3 years ago

mayanksuman commented 3 years ago

Minor code changes based on suggestion from CodeQL and QT creator.

mayanksuman commented 3 years ago

@jahnf , the continueOnError argument is not being used in function SubHidppConnection::sendDataBatch and SubHidppConnection::sendRequestBatch.

jahnf commented 3 years ago

@jahnf , the continueOnError argument is not being used in function SubHidppConnection::sendDataBatch and SubHidppConnection::sendRequestBatch.

It is used right immediately in the postSelf call (e.g. line 204)

jahnf commented 3 years ago

@jahnf , the continueOnError argument is not being used in function SubHidppConnection::sendDataBatch and SubHidppConnection::sendRequestBatch.

It is used right immediately in the postSelf call (e.g. line 204)

Ah I see, its duplicated.. (coe = continueOnError and continueOnError both in the lambda capture)

mayanksuman commented 3 years ago

The suggested reviews are now implemented.