Disable Git for version check.

jahnf / Projecteur

Linux Desktop Application for the Logitech Spotlight device (and similar devices) - Digital Laser Pointer

MIT License

379 stars 33 forks source link

Disable Git for version check. #18

Closed ConiKost closed 5 years ago

ConiKost commented 5 years ago

Currently, even on normal release, a Gitcheck is run to determinate version. So on a release zip, this will fail and produce a 0.0 version.

This check should depend on CMAKE_BUILD_TYPE =! Release or something like this.

jahnf commented 5 years ago

You are right, the build should work without being within a git repository. (It has nothing to do with the CMAKE_BUILD_TYPE though). I will look into it.

jahnf commented 5 years ago

2ba77b9c118dfae82e1763ddb2399f7718d4c677 should fix this issue, at least for (zip) archives for the current develop branch and future releases. While a version is now generated it is not as detailed as when building with sources from within the git repo.

If there are still issues feel free to comment and re-open.

ConiKost commented 5 years ago

Great! Many thanks. Works fine here.