Feature: border around spotlight

jahnf / Projecteur

Linux Desktop Application for the Logitech Spotlight device (and similar devices) - Digital Laser Pointer

MIT License

379 stars 33 forks source link

Feature: border around spotlight #32

Closed mayanksuman closed 4 years ago

mayanksuman commented 4 years ago

A border is made around the spotlight, which may help in accentuating the content.

A border is further useful for implementing pointer and zoom mode as they have borders around them as per #14 .

The current implementation is limited in the sense it do not work with Custom QQuickItem element if they do not have border properties defined.

jahnf commented 4 years ago

Hi @mayanksuman, thanks for the pull request. Did you create a branch of the zoom feature branch? Because there are two commits within your pull request (from @rj-jesus) that should for now stay on that feature branch. Could you create a pull request without those please? For the rest of the commits - I will look through it tonight or tomorrow.

mayanksuman commented 4 years ago

@jahnf Yes, I created the branch from zoom feature branch by mistake. I have tried to rebase it now.

jahnf commented 4 years ago

Code looks good, but if the border is not supported by all shapes, this will end with issue reports like "border does not work..." , so my proposal is one of the two (or both):

analogue to the allowSpotRotation for shapes there could be sth like supportsBorder and if a shape is selected that does not support the border the whole border group box will be disabled.
implement the border for all the current custom items.

The first one will be definitely the quicker one :)

jahnf commented 4 years ago

Thanks @mayanksuman , will have another look tomorrow and probably merge, going offline now.
For the shapes that don't support a border (for) now - and the automatically disabling of the border group box - do you want to implement that? (I can also do that maybe tomorrow)

mayanksuman commented 4 years ago

I am currently targeting to implement border on all custom shapes. Please feel free to implement the disabling of border groupbox if the shape do not have a border property.

jahnf commented 4 years ago

After thinking about it the shapes don't need a border property at all if we would use a second opacity mask to create a border. This would support all custom shapes. I'll post an example tomorrow or Wednesday.. so you don't need to implement a border for the custom shapes.

In any case: will merge tomorrow and then adjust afterwards

mayanksuman commented 4 years ago

That will be great. I will stop working on this and will focus on other issues.