search

jahnf / Projecteur

Linux Desktop Application for the Logitech Spotlight device (and similar devices) - Digital Laser Pointer
MIT License
379 stars 33 forks source link

Add zoom to commands #45

Closed mlouielu closed 4 years ago

mlouielu commented 4 years ago

This is a prototype for #44, which made Projecteur can toggle zoom from the command line.

I'm not sure if the m_settings init works idiomatically or not, please correct me if I'm wrong.

jahnf commented 4 years ago

There are 3 things I'd like to consider in regards of #44:

  1. On branch feature/follow-cursor-across-screens with e4efcb8a I already made the settings a member variable. Not a big issue but I want to avoid merge conflicts.
  2. Every setting works correctly wether the spot is shown or not, except zoom. The necessary screenshot can only be taken before the spot is shown and currently is only taken if the zoom is enabled - which avoids the extra screenshot step for users that don't use the zoom.
  3. The current approach of having an if/else for every setting doesn't scale well and will be ugly and painfully to maintain if more/all options are added. Maybe a settings/cmd map within Settings or sth similar would be good. But I need to try out a few things for that first.