jahnf / Projecteur

Linux Desktop Application for the Logitech Spotlight device (and similar devices) - Digital Laser Pointer
MIT License
379 stars 33 forks source link

AUR Package for Arch Linux #53

Closed m4dz closed 4 years ago

m4dz commented 4 years ago

Hi there!

thanks for the good work on this app!

I've just published a package for the upstream version on AUR, so the package is available to all Arch Linux users from their package manager. I'll maintain it stick to the develop branch.

Thanks again 👋 !

jahnf commented 4 years ago

Oh cool very nice :+1: I am not running arch Linux, but I have a question about the package version number though: wouldn't it be better to match the number compiled into the executable instead of just a git distance? I generate an arch Linux compatible version string anyway for the automated build in travis. I could put that version into a file (at CMake generation time) that you can use for the package version if that helps packaging.

jahnf commented 4 years ago

The files version-string and version-string.archlinux are created now during the CMake run, which would allow you to run CMake during [prepare()](https://wiki.archlinux.org/index.php/Creating_packages#prepare()) and use the version-string.archlinux file in [pkgver()](https://wiki.archlinux.org/index.php/creating_packages#pkgver())

prepare() {
  mkdir -p "$srcdir/build"
  cd "$srcdir/build"
  cmake "$srcdir/$_gitname"
}

pkgver() {
  cd "$srcdir/build"
  cat ./version-string.archlinux
}
m4dz commented 4 years ago

Great!

As Arch provides some guidelines for [VCS Packages](https://wiki.archlinux.org/index.php/VCS_package_guidelines#The_pkgver()_function), I've used the version-string.archlinux and append the git distance and commit hash. It works great!

I also published a regular version for the latest release based on tag.

Thanks for tha good work!

jahnf commented 4 years ago

Upvoted your AUR packages :)

Edit: I'll put a note for the AUR repos into the README together with the next README changes.