jahongiry / Organizer-Ruby_Capstone-project

MIT License
3 stars 1 forks source link

Ruby capstone project: Setting up Kanban board #25

Open jahongiry opened 1 year ago

jahongiry commented 1 year ago

https://github.com/jahongiry/Organizer-Ruby_Capstone-project/projects/1 In this Ruby capstone project, there are three Micronauts in our team: Team member #1: @jahongiry Team member #2: @Profsain Team member #3: @Sahar-SE.

ShoiraTa commented 1 year ago

STATUS: CHANGES REQUIRED 🟡

Hi team,

:thumbsup: This is good to make it this far, your project is really nice, congratulations on the good work you have done so far.

There are some issues that you still need to work on to go to the next project but you are almost there!

woohoo-youre-almost

Required Changes :recycle:

  1. descriptive title.
  2. the number of points in the [Xpt] prefix.
  3. a description of the task.

But your cards have no description. I understand that it might be time consuming adding descriptions, but you can share this task between all members, so that everyone adds a description to the card they have been assigned to.

Screenshot 2022-09-13 at 10 18 31

Please make sure that

Cheers and Happy coding! :clap: :clap: :clap:

Feel free to leave any questions or comments in the PR thread by mentioning my Github username if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

BenMukebo commented 1 year ago

Status: Approve :champagne: :+1: :confetti_ball: ### **Hi @Team** ### **Congratulations! 🎉 Project Approved ✅** Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: ### To Highlight :1st_place_medal: - You have a link to the GitHub project. ✔️ - There is Information about the number of people in you group :heavy_check_mark: - List of GitHub usernames is present, keep rocking :rocket: ## Optional suggestions _Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application._ - [ ] For more redability, you could also specify the `Team member #1`, `Team member #2`, ... or `Group task` in this way: ![18](https://user-images.githubusercontent.com/79058364/189869781-eff0a79e-43b2-46a8-9150-0ef4b3e676aa.png) Cheers :clinking_glasses: and Happy coding!!! :dancers:💻 Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please ping me @BenMukebo when you comment so I can receive the notification. ------ _As described in the [Code reviews limits policy](https://microverse.zendesk.com/hc/en-us/articles/1500004088561) you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using [this form](https://airtable.com/shrQAqnBwek5a0O0s)._