search

jahrlin / genius-api

node.js client for the Genius API
MIT License
17 stars 7 forks source link

Moved "lodash" to dependencies #1

Closed ShyykoSerhiy closed 7 years ago

ShyykoSerhiy commented 7 years ago

"lodash": "^3.9.3" isn't devDependency. You have require in dist.

jahrlin commented 7 years ago

thanks!

Poitrin commented 7 years ago

Hello! Did you publish this change on npm? I still get the error message that lodash can’t be found.

/node_modules/genius-api/package.json still lists lodash under "devDependencies". When I move it to "dependencies" and reexecute npm install, it works fine though.

Thanks!

jahrlin commented 7 years ago

Thanks for the heads up! I have updated the package on npm, version 0.4.1 :)

Cheers

On Fri, Aug 11, 2017 at 7:50 PM Julien Poitrin notifications@github.com wrote:

Hello! Did you publish this change on npm? I still get the error message that lodash can’t be found.

/node_modules/genius-api/package.json still lists lodash under "devDependencies". When I move it to "dependencies" and reexecute npm install, it works fine though.

Thanks!

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/jahrlin/genius-api/pull/1#issuecomment-321877475, or mute the thread https://github.com/notifications/unsubscribe-auth/ACCF-SMqCwSSNlYF5Kn3HljvfJHTFezTks5sXJRtgaJpZM4MiqZ0 .