search

jai-dewani / memeify

A meme creator webapp made using React
https://jai-dewani.github.io/memeify/
The Unlicense
17 stars 17 forks source link

User should be able to edit the size of text #35

Closed jai-dewani closed 2 years ago

UnknownAbyss commented 2 years ago

Hello. I would like to take up this issue. Can you explain how exactly you want the changes to function?

jai-dewani commented 2 years ago

Thanks for reaching out Additya,
you can use this website for reference -> https://imgflip.com/memegenerator.
Don't take it as me asking for a complete replica, but just a base point on how it should function >_<

UnknownAbyss commented 2 years ago

So do you just want me to add 2 buttons that let you increase/decrease text size? xD

UnknownAbyss commented 2 years ago

image I have implemented the feature for setting text size in pixels. You can go through it in the following commit :)

UnknownAbyss commented 2 years ago

Heya. Could you please take a look at my PR? Thanks ^_^

jai-dewani commented 2 years ago

This PR has introduced a new bug where the text is only draggable if the text is selected where it was originally before changing the resizing of text. It is now being tracked here #55