Add hover text for color input elements

jai-dewani / memeify

A meme creator webapp made using React

https://jai-dewani.github.io/memeify/

The Unlicense

17 stars 17 forks source link

Add hover text for color input elements #44

Closed jai-dewani closed 3 years ago

jai-dewani commented 3 years ago

In displayMeme.js file

"Text Colour" for the first color input
"Border Colour" for the second color input

Yash-271120 commented 3 years ago

Hi, can you assign this issue to me. If it has not yet been fixed. I know react but I am new to open source looking for contributions!

jai-dewani commented 3 years ago

Thanks for reaching out @Yash-271120!
Yes, this still has to be fixed, so I am assigning this issue to you.

Yash-271120 commented 3 years ago

@jai-dewani I think the bug is already been fixed. It works same as stated here #44

jai-dewani commented 3 years ago

Oh no, the hover text is still missing. There is no bug in the colour selection process, I just didn't want the users to get confused about which colour is for what, so I added this issue to have hover texts

Yash-271120 commented 3 years ago

Ok I get it now!

Likkiii commented 3 years ago

Hello, I'd like to take this issue up.

jai-dewani commented 3 years ago

Thanks for reaching out Likhit Sure, I will assign this issue to you :)

Likkiii commented 3 years ago

Hello, it'd be really great if you could review my PR Thanks :)

jai-dewani commented 3 years ago

This has been fixed with #53