search

jai-dewani / memeify

A meme creator webapp made using React
https://jai-dewani.github.io/memeify/
The Unlicense
17 stars 17 forks source link

Added Hover Effect #45

Closed Yash-271120 closed 2 years ago

Yash-271120 commented 3 years ago

Adding the hover effect was actually difficult. I used gsap for it. refer here for gsap docs.

jai-dewani commented 3 years ago

There seems to be some build error, kindly check that and also make sure you add the new packages to package.json.

I don't know much about gasp so maybe you can answer this better, do we really need another library for doing hover text? I have seen simpler text hover using plain CSS, does this implementation provides any additional benefits?

Yash-271120 commented 3 years ago

Hover effect using plain CSS can be done but on hover changes to css can be applied to that element only which we are hovering. In our case that element was input. That's why as a way around I used gsap.

jai-dewani commented 3 years ago

Okay, go ahead and fix the build errors and don't forget to add the new dependency to package.json, or other's will have to install this new package separately even after doing npm install

Yash-271120 commented 3 years ago

I think the build error is gone now!

jai-dewani commented 3 years ago

It's still there @Yash-271120 Can you run the build process locally once before pushing just to check?

The error seems to be 

./src/components/MemeGen.js
Cannot find file './DisplayMeme' in './src/components'.
Yash-271120 commented 3 years ago

Yes I build it locally it worked fine. I really can't find the problem here!

jai-dewani commented 2 years ago

Closing this PR because no activity in the last 4 months