search

jai-imageio / jai-imageio-jpeg2000

JPEG2000 support for Java Advanced Imaging Image I/O Tools API
Other
73 stars 56 forks source link

jj2000: StdEntropyCoder: Use the lossless distortion tables #20

Closed rleigh-codelibre closed 3 years ago

rleigh-codelibre commented 7 years ago

From https://github.com/rleigh-codelibre/jai-tidy/commit/43c88850a1e6ffb25fa513be8868b719a1f3b49a

This PR is not necessarily appropriate to merge. Are there situations where we want to use the lossy tables? Should this be configurable? If so, how should it be done? Could we add it to StdEntropyCoderOptions?

/cc @melissalinkert

melissalinkert commented 7 years ago

I think https://github.com/rleigh-codelibre/jai-imageio-jpeg2000/blob/bc0ea6807edc6fd498e5b7e5014456bf33f95a03/src/main/java/com/github/jaiimageio/jpeg2000/impl/J2KImageWriter.java#L324 and https://github.com/rleigh-codelibre/jai-imageio-jpeg2000/blob/bc0ea6807edc6fd498e5b7e5014456bf33f95a03/src/main/java/jj2000/j2k/entropy/encoder/EntropyCoder.java#L310 together mean that the J2KImageWriteParam (which contains boolean getLossless()/setLossless(boolean)) is available to EntropyCoder, but is not passed on during the creation of StdEntropyCoder. Passing J2KImageWriteParam through to StdEntropyCoder and checking the value of getLossless() is hopefully then sufficient without modifying StdEntropyCoderOptions.

rleigh-codelibre commented 3 years ago

I'm not doing work on this going forward. If anyone wants to pick this up, please feel free to do so.