bug/clicking-hub-button-no-gps-jaia-1520

jaiarobotics / jaiabot

Jaiabot source code

Other

20 stars 2 forks source link

bug/clicking-hub-button-no-gps-jaia-1520 #946

Closed edsanville closed 4 weeks ago

edsanville commented 1 month ago

Add type information to the HubContext variable.
Change the type of HubContextType.hubStatuses variable to be a hash of hub_id to PortalHubStatus.
Added the optional chaining operator to hubStatus?.location?.lat and lon
Change name of HubContextType.hubStatus to hubStatuses to indicate that it's a map onto PortalHubStatus objects.
Changed "Octal" to "Octet"
Don't return early before all hooks are generated (React doesn't like this and produces a console warning).

edsanville commented 1 month ago

Regarding the HubContext variable: should be change this to hubContext to keep in line with the convention of only capitalizing types and not variables?

michael-jaia commented 1 month ago

Deployed to Fleet 1, Hub 1
Tested on hub with and without a GPS fix (no crashes, and expected values displayed)
Clicked through HubDetails panel checking for undefined crashes (no crashes)