An error was thrown for hubs with an ID of 0 as the code intended to catch non-numerical hub IDs. Hub IDs of 0 have been depreciated, but to remain compatible with older hubs, this PR uses isNaN to validate the hub ID is a number.
Additionally, this PR removes the goby_intervehicle_subscriptions_hub.pb.txt file to prevent disconnected bots from appearing in the JCC.
Testing
Configured the ghost hub as Fleet 1, Hub 0. No error is thrown when opening the hub details panel now.
Removed goby_intervehicle_subscriptions_hub.pb.txt from Fleet 1, Hub 0 and watched it repopulate after a hard reboot.
Summary
An error was thrown for hubs with an ID of 0 as the code intended to catch non-numerical hub IDs. Hub IDs of 0 have been depreciated, but to remain compatible with older hubs, this PR uses
isNaNto validate the hub ID is a number.Additionally, this PR removes the
goby_intervehicle_subscriptions_hub.pb.txtfile to prevent disconnected bots from appearing in the JCC.Testing
Configured the ghost hub as Fleet 1, Hub 0. No error is thrown when opening the hub details panel now. Removed
goby_intervehicle_subscriptions_hub.pb.txtfrom Fleet 1, Hub 0 and watched it repopulate after a hard reboot.