search

jaidetree / cljs-tui-template

A leiningen template to generate ClojureScript Terminal-User-Interface applications built on web technologies you already know.
Apache License 2.0
230 stars 9 forks source link

Credit? #5

Closed polymeris closed 5 years ago

polymeris commented 5 years ago

Hello,

as you can tell from the initial commit, floki is based on my hello-react-blessed gist. Of course you have taken this to a whole other level, but would you mind crediting me for the original implementation/idea?

jaidetree commented 5 years ago

Thanks for the initial research! I’ll update the README, the demo app, and the source comments and docstrings. Should be able to get that up today.

polymeris commented 5 years ago

Thank you!

jaidetree commented 5 years ago

All set! I'll re-record the intro gif as well at a later date and time so the new blurb about your work is displayed. Thanks again.

polymeris commented 5 years ago

I see, even my "debug info" panel persisted into your implementation. To be honest, I am flattered that this got so much traction.

How did you solve the issue of console.log messing with the rendering and instead redirecting logs to the panel? Is my (set! (.-log js/console) log-fn) hack still buried somewhere?

jaidetree commented 5 years ago

Agreed, the response has been pretty positive! I'm sorry I didn't find out about your gist sooner though.

Whew! I think that's everything.

jaidetree commented 5 years ago

Also, your log overrides also made their way into the codebase too:

https://github.com/eccentric-j/cljs-tui-template/blob/master/resources/leiningen/new/cljs_tui/env/dev/app.cljs#L37

The rest of the changes above can be seen here: https://github.com/eccentric-j/cljs-tui-template/compare/dea00684aaa813c1f9d4df032b5cca703369eaac...6ad22eb0d069666a072c58709fc82e6f1a2ca8c3