search

jaidetree / lein-rebl-example

Example and instructions to use REBL with Leiningen's REPL.
27 stars 2 forks source link

Additional dependencies for Java 11 #2

Open eggsyntax opened 5 years ago

eggsyntax commented 5 years ago

Hi Eccentric-J, thanks for writing this up! You may want to add that for Java 11, the following additional dependencies are required:

[org.openjfx/javafx-fxml     "11.0.1"]
[org.openjfx/javafx-controls "11.0.1"]
[org.openjfx/javafx-swing    "11.0.1"]
[org.openjfx/javafx-base     "11.0.1"]
[org.openjfx/javafx-web      "11.0.1"]

Those are given for deps.edn here, but it's easy to miss when looking at your document for instructions (or I missed it, anyway ;P ). Thanks again!

jaidetree commented 5 years ago

Thanks, I think this repo needs some updating to keep up with the clearer view of how this all fits together. I'll get started on that tomorrow.

On Tue, Jun 4, 2019 at 1:01 PM Egg Syntax notifications@github.com wrote:

Hi Eccentric-J, thanks for writing this up! You may want to add that for Java 11, the following additional dependencies are required:

[org.openjfx/javafx-fxml "11.0.1"] [org.openjfx/javafx-controls "11.0.1"] [org.openjfx/javafx-swing "11.0.1"] [org.openjfx/javafx-base "11.0.1"] [org.openjfx/javafx-web "11.0.1"]

Those are given for deps.edn here https://github.com/cognitect-labs/REBL-distro/wiki/Java-11-Usage, but it's easy to miss when looking at your document for instructions (or I missed it, anyway ;P ). Thanks again!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/eccentric-j/lein-rebl-example/issues/2?email_source=notifications&email_token=AAEQDWMTVJZJ35RTPXRXIMDPY2NXDA5CNFSM4HS7ELH2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GXSTOGA, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEQDWMRRBB6VRNUCTD3HO3PY2NXDANCNFSM4HS7ELHQ .

eggsyntax commented 5 years ago

I should probably clarify that I don't actually have it fully working (I can start the UI, and I can type stuff in the UI that'll be represented, but stuff I type in the REPL doesn't show up in the UI, unlike the deps.edn version). But adding the openjfx dependencies at least got me as far as being able to start the UI :laughing:

sogaiu commented 4 years ago

So it turns out that recently if one does not put:

[cljfmt "0.6.4"]

in project.clj, starting the ui may lead to:

Execution error (FileNotFoundException) at cognitect.rebl.impl.monaco/loading (monaco.clj:3).
Could not locate cljfmt/core__init.class, cljfmt/core.clj or cljfmt/core.cljc on classpath.

This was with REBL-0.9.218 using Java 11.

Seems similar to: https://github.com/cognitect-labs/REBL-distro/issues/34

May be there's another way to address this?