search

jaidevd / pyhht

Python toolbox for the Hilbert-Huang transform
Other
254 stars 88 forks source link

starting python3 compatibility mods #21

Closed maurotoro closed 8 years ago

maurotoro commented 8 years ago

This are the most basic changes needed for python3 compatibility. Still need to edit the docstrings and learn more about the whole git usage.

Thanks for this beautiful project!

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 71.19% when pulling 3fc64fadc898f14d8acc16e35c55b9a95fc10913 on maurotoro:dev into 51d5abee0a81ae79b81a215117ad787949edc913 on jaidevd:dev.

jaidevd commented 8 years ago

@maurotoro Thanks for this. This is good for a start. As we add more functionality and improve the project, we will have to think more carefully about Python3 compatibility. Anyway, do you intend to add more commits or is this all you had in mind for now?

maurotoro commented 8 years ago

the docstrings need changes, but this changes are the more relevant for compatibility. In terms of functionality, I'm still learning about EMD and it's applications, so for now I would like to propose to implement tests like the one proposed in this paper: http://www.ncbi.nlm.nih.gov/pubmed/17273939 . They propose a test for phase locking relevant for neuroscience that seems that could spark more interest on the HHT in the field. They also mention other interesting test for phase locking, PLS and S-PLS proposed some time ago. But maybe those are more relevant or on the lines of projects like circstats. Hope to collaborate on this project more! Mucha Suerte!

On Wed, Jul 27, 2016 at 11:06 AM, Jaidev Deshpande <notifications@github.com

wrote:

@maurotoro https://github.com/maurotoro Thanks for this. This is good for a start. As we add more functionality and improve the project, we will have to think more carefully about Python3 compatibility. Anyway, do you intend to add more commits or is this all you had in mind for now?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jaidevd/pyhht/pull/21#issuecomment-235543414, or mute the thread https://github.com/notifications/unsubscribe-auth/AHY4H5DxO6leHpI5PRHQmlHfaqr5UgOxks5qZy2sgaJpZM4JWBic .

Mauricio Toro E. INDP2015@CR.CCU.PT INDP2015@CNP.CCU.PT Champalimaud Centre for the Unknown, Avenida Brasília, 1400-038 Lisbon, Portugal.

+351 91 856 3868

jaidevd commented 8 years ago

👍