Refactor/cleanup - Githubissues

jaihysc / Jactorio

Recreating Factorio in C++ OpenGL

Other

75 stars 2 forks source link

Refactor/cleanup #28

Closed jaihysc closed 3 years ago

jaihysc commented 3 years ago

Data structures

Convert Orientation and related functions to class and methods
Convert inventory_controller into object
Join placement_controller into World
Convert GameDataGlobal to GameController, containing game init/update logic
Move global Renderer* to member of ThreadedLoopCommon
Remove ChunkTileLayer, layers are now stored in the Chunk

Functions

Add PrototypeManager GetAll overload which infers category
Remove LocalparseNoThrow (Actually could throw)
Remove need for MouseSelection SkipErasingLastOverlay
Add method for incrementing WorldCoord (Previously many methods with different names)
Replace functions taking (x, y) with coordinate object
Remove World GetTopLeft methods
World OnBuild/Remove provides TileLayer
Remove GameController::ClearRefsToWorld

Tests

Clean up world placement tests
Remove unnecessary heap allocation in tests

Formatting

Switch to direct initialization for objects
Remove extra line above documentation comments