search

jaikeerthick / Composable-Graphs

✨ A very Minimal, Sleek and Powerful Graph library for Android built with Kotlin & Jetpack Compose
Apache License 2.0
191 stars 13 forks source link

Support Compose Multiplatform? #32

Closed sunny-chung closed 8 months ago

sunny-chung commented 8 months ago

Would you support Compose Multiplatform?

I just have a quick look on the source code. It seems the core does not depend on Android-specific stuffs, so it might not be difficult. If you have no time, would you accept a PR?

jaikeerthick commented 8 months ago

Hey @sunny-chung, Thank you for your interest in Composable Graphs library. Yes the library doesn't depend on Android-specific things. Adding support for Compose Multiplatform sounds like a valuable addition, and I appreciate your willingness to contribute.

I'm open to accepting a pull request (PR) for this feature if you're willing to work on it. Feel free to go ahead and submit a PR whenever you're ready. If you have any questions or need guidance along the way, don't hesitate to ask. Your contribution to the project is greatly appreciated!

sunny-chung commented 8 months ago

I can do that, but there will be a breaking change for you. Jitpack does not build Apple OS artifacts. To support multiplatform, perhaps you would have to move to Maven Central, which requires you to changing the library group ID to "io.github.jaikeerthick".

jaikeerthick commented 8 months ago

I understand the requirements and challenges to migrate to KMM. The library still need to mature a lot and therefore I'm planning to not to support KMM as of now and I promise that the library will continue to have pure kotlin code and no Android-specific dependencies so that in future It'll be easy to support KMM.

Thanks.