search

jaikumarm / docker-iqfeed

Dockerized IQFeed client with X11VNC for remote viewing
37 stars 25 forks source link

Documentation Port Number Error #12

Closed giranntu closed 10 months ago

giranntu commented 10 months ago

Hello,

It's a nice docker app that I recently start focus on it(quant related project). I noticed a small error in the documentation of the docker-iqfeed repository. In the README.md file, under the Socket Connections section, the default port number for Level1Port is mentioned as 5009. However, in the Docker run command in the Usage section, the port mapping is given as -p 5009:5010. which is wrong (https://www.iqfeed.net/dev/api/docs/Introduction.cfm)

I believe the correct port should be 5009, not 5010. This discrepancy might cause confusion for users trying to set up the IQFeed client.

just an small README error msg, but not critical, thanks again for providing this project

jaikumarm commented 10 months ago

Hi, Yes you are correct that port mapping is incorrect. I used have a proxy js script mapping iqfeed 5009 to 5010 internally in the container and docker run command would reverse map to container 5010 to external 5009. this has not been the case since I binary patched the iqfeed client to listen to non localhost ip. I will fix the doc, thanks for the feedback.