search

jaime-olivares / zipstorer

A Pure C# Class to Store Files in Zip
MIT License
183 stars 63 forks source link

Fixed errors in VB version #2

Closed cloudflying closed 9 years ago

cloudflying commented 9 years ago

Corrected problems with line endings / comment wraps.

jaime-olivares commented 9 years ago

Hi there, I have tried to understand what you have corrected, but as you have changed all the spacing in the source code file, every single line looks like a change.

cloudflying commented 9 years ago

Hi, That was actually what I fixed. The spacing / line breaks were out of whack and wouldn't build / compile correctly. Then I am sure some Visual Studio voodoo happened when saving as well.

Here is diffcheckers version of the two files side by side, still not great, but a little easier to see what changes I made.

https://www.diffchecker.com/loowokws

If you want I can close this pull request and mark up exactly which lines I updated.

Justin.

jaime-olivares commented 9 years ago

Hi Justin, could you please start over without moving the tab spacing? I think that will better reflect your changes.

cloudflying commented 9 years ago

Yes, that was on my list of things to do today. Plus I am going to use Sublime instead of Visual Studio.

Justin

From: Jaime Olivaresmailto:notifications@github.com Sent: ‎10/‎20/‎2015 12:04 AM To: jaime-olivares/zipstorermailto:zipstorer@noreply.github.com Cc: Justin Portermailto:justin@textconnects.com Subject: Re: [zipstorer] Fixed errors in VB version (#2)

Hi Justin, could you please start over without moving the tab spacing? I think that will better reflect your changes.

— Reply to this email directly or view it on GitHubhttps://github.com/jaime-olivares/zipstorer/pull/2#issuecomment-149425527.

cloudflying commented 9 years ago

I have updated the file and it should give you a better overview of the changes.

Justin

jaime-olivares commented 9 years ago

Got it. Thanks for your contribution.