search

jaime-olivares / zipstorer

A Pure C# Class to Store Files in Zip
MIT License
183 stars 63 forks source link

Support Net6 #50

Closed A9G-Data-Droid closed 3 months ago

A9G-Data-Droid commented 11 months ago

I have removed all unsupported .net versions. By targeting only .netstandard2.0 this library can support any project that is Framework 4.6.2+, which is the lowest currently supported version. This has greatly simplified the codebase.

I upgraded the test project to .NET6, and moved the required CodePages calls to the constructor of ZipStorer. This proves that the change fixes the issue #43, which affects all modern users of this library due to changes in .NETCore.

jaime-olivares commented 3 months ago

I cannot accept this PR for the same reasons explained here: https://github.com/jaime-olivares/zipstorer/pull/51#issuecomment-2211061295

PRs should cover a concrete issue. A total revamp like this one should be extensively coordinated with the project manager.

jaime-olivares commented 3 months ago

I have created a new version 4, based on a couple of individual commits and also suggestions from other users.