jaimehgb / RaiWebWallet

Raiblocks raiwallet.com wallet source code
http://raiwallet.com
GNU General Public License v3.0
112 stars 37 forks source link

Add package json and delete node_modules #12

Open weeska opened 6 years ago

weeska commented 6 years ago

Hi there.

I thought it would be more straight-forward to have a package.json describing the project's dependencies. I don't know if you're familiar with node.js, but this way you can just type npm install and it installs all dependencies - no need to push them.

Things that I've changed:

bkmeneguello commented 6 years ago

Not all dependencies are resolved yet, hum? It's not possible to use as node dependency. I think core could be split as standalone library.

s123121 commented 6 years ago

This need to be done ASAP because no professional developers would commit node_modules into git. This will more or less affect the RaiWallet credibility

weeska commented 6 years ago

@bkmeneguello npm init automatically writes packages from the node_modules folder into the generated package.json. So all dependencies should be resolved. I also removed the nacl folder as it did not seem to be used.

I wonder if there is some sort of CI system. It's hard to see what's effected by changes.

jaimehgb commented 6 years ago

Hmm @chriscohoat did the same here: https://github.com/jaimehgb/RaiWebWallet/pull/5

He also moved Wallet.js and Block.js (the wallet itself) into a new and self-contained repo: https://github.com/chriscohoat/rai-wallet

I think that's the way to do it, still have to test his branch though (cough) :)

weeska commented 6 years ago

I'm fine with closing this one if the PR of @chriscohoatgets gets merged. Either way there is some work to be done to enable other developers to help.