Closed madhur87 closed 1 year ago
@madhur87 Please change the title of PR to something like
feat(backend): added joi validation and error handling and jwt
to pass the PR title lint test case
Hey @madhur87 could you make the changes specified by @MahendraDani, also there are some merger conflicts I will check it and get back to you!
Okay i made changes.
@madhur87 can you tell me what all dependencies have you added, since it's showing some merge conflicts in package.json!
Fix everything, and I have added one more regarding esLint to follow everyone's same code format. Please review and MR @apeksha235 @jain-rishabh-21
@apeksha235 the package.json conflicts for these packages joi, eslint, jsonwebtoken.
It would be great to add a lint script in the pipeline @jain-rishabh-21
@madhur87 we had to remove the lint script from the pipeline due to some errors
Yeah, i know that's why I have add only in package file
After merge this MR then we can create a workflow for eslint.
@apeksha235 it's good to be merge
Thanks a lot @apeksha235
hey @madhur87 it seems like you haven't pulled the code after a merge that i did yesterday, can you check it please?
I already pull the latest code and merge that in this branch. @apeksha235
In this MR:->
Please review and merge this MR @jain-rishabh-21, Thanks #58