jain-rishabh-21 / DoctorVerse

An application that will help people find doctors and hospitals nearby along with the ratings and facilities available
MIT License
33 stars 54 forks source link

feat(backend): added joi validation and error handling, jwt and eslint #71

Closed madhur87 closed 1 year ago

madhur87 commented 1 year ago

In this MR:->

  1. Implement JWT
  2. Joi Validation
  3. Error Handling
  4. Add User Update Controller
  5. Restructure Server Folder'
  6. Add ESlint with rules
  7. Add ESlint Fix Script in Package.json

Please review and merge this MR @jain-rishabh-21, Thanks #58

MahendraDani commented 1 year ago

@madhur87 Please change the title of PR to something like feat(backend): added joi validation and error handling and jwt to pass the PR title lint test case

apeksha235 commented 1 year ago

Hey @madhur87 could you make the changes specified by @MahendraDani, also there are some merger conflicts I will check it and get back to you!

madhur87 commented 1 year ago

Okay i made changes.

apeksha235 commented 1 year ago

@madhur87 can you tell me what all dependencies have you added, since it's showing some merge conflicts in package.json!

madhur87 commented 1 year ago

Fix everything, and I have added one more regarding esLint to follow everyone's same code format. Please review and MR @apeksha235 @jain-rishabh-21

@apeksha235 the package.json conflicts for these packages joi, eslint, jsonwebtoken.

madhur87 commented 1 year ago

It would be great to add a lint script in the pipeline @jain-rishabh-21

apeksha235 commented 1 year ago

@madhur87 we had to remove the lint script from the pipeline due to some errors

madhur87 commented 1 year ago

Yeah, i know that's why I have add only in package file

After merge this MR then we can create a workflow for eslint.

@apeksha235 it's good to be merge

madhur87 commented 1 year ago

Thanks a lot @apeksha235

apeksha235 commented 1 year ago

hey @madhur87 it seems like you haven't pulled the code after a merge that i did yesterday, can you check it please?

madhur87 commented 1 year ago

I already pull the latest code and merge that in this branch. @apeksha235