feat(frontend): adding routing with router-dom - Githubissues

jain-rishabh-21 / DoctorVerse

An application that will help people find doctors and hospitals nearby along with the ratings and facilities available

MIT License

33 stars 54 forks source link

feat(frontend): adding routing with router-dom #81

Closed SantiagoEscalante closed 1 year ago

SantiagoEscalante commented 1 year ago

Related Issue

Info about the related issue

Closes: #[issue number that will be closed through this PR]

Describe the changes you've made

Give a clear description what modifications you have made

Type of change

What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Enhancement in the existing features
[ ] Other

Mention any unusual behaviour of your code (Write NA if not)

Any unusual behaviour of your code

Checklist:

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly whereever it was hard to understand.
[x] My changes generate no new warnings.
[x] I have verified/tested my code by running it locally.

Files Added/Modified

[List the files you have added or modified in this pull request.]

Screenshots / Videos / Gif

[Insert screenshots or videos demonstrating the changes you made.]

Additional Info (optional)

Any additional information you want to give

apeksha235 commented 1 year ago

Hey @SantiagoEscalante can you just change the pr title to the instructiors mentioned in contribution.md! since one of the checks is failing

apeksha235 commented 1 year ago

@SantiagoEscalante , start with a lower-case, like feat(frontend): adding routing, thanks