jainishsenjaliya / js_faq

FAQ - Frequently Asked Questions
4 stars 7 forks source link

Only one category assignable #13

Open christian-fries opened 7 years ago

christian-fries commented 7 years ago

You created an mm table for faq and category and created the category in the model as ObjectStorage, so it should be possible to assign multiple categories to one faq.

Why do you restrict the category selection to only one category in TCA (_Configuration/TCA/Overrides/tx_jsfaq_domain_modelfaq.php)? $GLOBALS['TCA']['tx_jsfaq_domain_model_faq']['columns']['category']['config']['size'] = 1; $GLOBALS['TCA']['tx_jsfaq_domain_model_faq']['columns']['category']['config']['autoSizeMax'] = 1; $GLOBALS['TCA']['tx_jsfaq_domain_model_faq']['columns']['category']['config']['maxitems'] = 1;

jainishsenjaliya commented 7 years ago

Thanks for an update.

That was i am thinking about multiple category option. but main problem is..m if i set multiple category in every FAQ and in plugin option i have given option for display FAQ category wise. that time that FAQ will repeat in both category option.

That is why i have not added that option. let me know your opinion.

Regards, Jainish

On Wed, Dec 7, 2016 at 5:06 AM, Shakeshake notifications@github.com wrote:

You created an mm table for faq and category and created the category in the model as ObjectStorage, so it should be possible to assign multiple categories to one faq.

Why do you restrict the category selection to only one category in TCA ( Configuration/TCA/Overrides/tx_jsfaq_domain_model_faq.php)? $GLOBALS['TCA']['tx_jsfaq_domain_model_faq']['columns']['category']['config']['size'] = 1; $GLOBALS['TCA']['tx_jsfaq_domain_model_faq']['columns'][ 'category']['config']['autoSizeMax'] = 1; $GLOBALS['TCA']['txjsfaq domain_model_faq']['columns']['category']['config']['maxitems'] = 1;

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jainishsenjaliya/js_faq/issues/13, or mute the thread https://github.com/notifications/unsubscribe-auth/AGVIphrfMx8poChkudv-PWRa_zBQwp11ks5rFfGVgaJpZM4LGBYj .

christian-fries commented 7 years ago

That's right but IMHO that's the correct way to handle this situation.

If I assign mutliple categories to a faq and I list all faq's, grouped by category, I'd expect the faq to be shown in all the groups of categories I assigned it. It's related to both groups, so I might look for it in both groups.

I'm currently evaluating faq extensions for TYPO3 and I like your extension so far. As the possibility to assign multiple categories is a requirement for an faq system IMHO, I'm wondering how you're planing to handle categories in future versions.

Kind regards, Chris

jainishsenjaliya commented 7 years ago

Ok, Chris

I will do it for multiple assign category

BTW this is my skype id : jainishsenjaliya

Kind Regards, Jainish

On Wed, Dec 7, 2016 at 10:23 PM, Shakeshake notifications@github.com wrote:

That's right but IMHO that's the correct way to handle this situation.

If I assign mutliple categories to a faq and I list all faq's, grouped by category, I'd expect the faq to be shown in all the groups of categories I assigned it. It's related to both groups, so I might look for it in both groups.

I'm currently evaluating faq extensions for TYPO3 and I like your extension so far. As the possibility to assign multiple categories is a requirement for an faq system IMHO, I'm wondering how you're planing to handle categories in future versions.

Kind regards, Chris

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jainishsenjaliya/js_faq/issues/13#issuecomment-265503034, or mute the thread https://github.com/notifications/unsubscribe-auth/AGVIplskdGaQFn3BxOslPDNrrw2V2efnks5rFuRtgaJpZM4LGBYj .

christian-fries commented 7 years ago

Hi Jainish

Thanks for the feedback! Do you want me to create a pull request?

Cheers Chris

jainishsenjaliya commented 7 years ago

Hey Chris,

If you don't mind than please share me that changes. because i also did it in my local system

Cheers Jainish