search

jainishsenjaliya / js_faq

FAQ - Frequently Asked Questions
4 stars 7 forks source link

Missing index in CategoryGroupWise Partial #15

Open nicodh opened 7 years ago

nicodh commented 7 years ago

The line

<div class="tx-jsfaq-category-faq" id="{settings.contentID}" >

in the for each="{FAQ}" loop in Partials/Template/CategoryGroupWise.html results in many div tags with the same ID attribute and prevents the jQuery('.tx-jsfaq-toggle-show-category-all') click handler to work as expected. Can be easily resolved with:

...
jainishsenjaliya commented 7 years ago

this will be unique content id

so it will not repeated

On Jun 13, 2017 2:18 PM, "Nico de Haen" notifications@github.com wrote:

The line

in the for each="{FAQ}" loop in Partials/Template/CategoryGroupWise.html results in many div tags with the same ID attribute and prevents the jQuery('.tx-jsfaq-toggle-show-category-all') click handler to work as expected. Can be easily resolved with:
...
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub , or mute the thread .
nicodh commented 7 years ago

It is the same ID in each for loop, so it gets repeated again and again...

jainishsenjaliya commented 7 years ago

ohhh thn i have to look again in this code.

thanks for information

will do changes later.

Thanks

On Jun 13, 2017 5:25 PM, "Nico de Haen" notifications@github.com wrote:

It is the same ID in each for loop, so it gets repeated again and again...

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jainishsenjaliya/js_faq/issues/15#issuecomment-308092731, or mute the thread https://github.com/notifications/unsubscribe-auth/AGVIpl5PshyYxjl8JuB2dcgogFEBmWxFks5sDniqgaJpZM4N4LIc .