search

jainishsenjaliya / js_guestbook

Simple Guest book with name, email, phone, www, title, message
1 stars 2 forks source link

Not compatible to PHP 5.6 #1

Open christian-fries opened 8 years ago

christian-fries commented 8 years ago

As already stated on TYPO3 Forge (https://forge.typo3.org/issues/76698), this extension is not compatible with PHP 5.6:

PHP Runtime Deprecation Notice: Non-static method JS\JsGuestbook\Service\Configuration::getSessionData() should not be called statically, assuming $this from incompatible context in \/home\/httpd\/vhosts\/web127\/httpdocs\/typo3conf\/ext\/js_guestbook\/Classes\/Controller\/GuestBookController.php line 63

You might want to use dependency injection for your service as TYPO3 suggests: https://wiki.typo3.org/Dependency_Injection#Extbase_4.7

jainishsenjaliya commented 8 years ago

Thanks for update.

I will check it in PHP lower version. i have tested in PHP 7.0.7 and it's working fine for me.

Better you upgrade you PHP version.

Regards, Jainish

jainishsenjaliya commented 8 years ago

Hey Christian,

Please have a look updated version

If you are still facing same issue thn let me know..

Regards, Jainish