search

jairovsky / mods-valheim

Collection of mods for Valheim
MIT License
0 stars 0 forks source link

error : Invalid framework identifier '' #1

Open jroubi opened 2 months ago

jroubi commented 2 months ago

Hello,

Firstly, thanks for sharing your findings. I've tried to build your fork of aedenthorn. But keep getting the same error.

I've downloaded .NET SDK 7 I've added the ValheimModBase.csproj.user file with my game path.

But when I try to build I get :

dotnet build --configuration Release C:\Users\Julien\Downloads\ValheimMods
MSBuild version 17.7.6+77d58ec69 for .NET
  Determining projects to restore...
C:\Program Files\dotnet\sdk\7.0.410\NuGet.targets(158,5): error : Invalid framework identifier ''. [C:\Users\Julien\Dow
nloads\ValheimMods\ValheimModBase.sln]

Build FAILED.

I've tried deleting the lines in the ValheimModBase.csproj file

  <ItemGroup Condition="'$(TargetFramework.TrimEnd(`0123456789`))' == 'net'">
    <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.2" PrivateAssets="all" />
  </ItemGroup>

But it didn't change the error.

Do you have any insight for me, any help would be greatly appreciated.

jroubi commented 2 months ago

I was mixing things and trying to build aedenthorn repo. Sorry for that. Everything works. Thanks for your repo.

jroubi commented 2 months ago

Sorry, yours work but I'm not able to reproduce the result with aedenthorn repo. How did you recompile without changing any lines. Your repo is very different from the original one.

jairovsky commented 2 months ago

Hello! Glad to hear the build process is working here :)

When I say I didn't change any line of code, I'm referring to the actual mod (the C# code), not the visual studio solution. I copied aedenthorn's C# code because his project configuration seems a bit complex and I ran out of patience trying to make the build process work on my machine.