jajm / koha-staff-interface-redesign

Koha fork - only for staff interface redesign (bug 30952)
GNU General Public License v3.0
1 stars 1 forks source link

Low constrast of some colors (WCAG) #10

Open black23 opened 2 years ago

black23 commented 2 years ago

For the sake of good readability and high accessibility of the new interface, we should fine-tune the colour contrasts. Ideally, to comply with WCAG requirements. The contrast ratio should be at least 4.5:1. In some places we are now reaching 2:1, which makes it less readable (for example, smaller green text on a white or grey background). obrazek

black23 commented 2 years ago

Examples of possible colors (contrast ration 4.5:1 or better):

mrenvoize commented 2 years ago

Once we've settled on colours, can we get them published in an official style guideline doc somewhere ;)

black23 commented 2 years ago

Yes! I agree.

Michal

po 5. 9. 2022 v 11:33 odesílatel Martin Renvoize @.***> napsal:

Once we've settled on colours, can we get them published in an official style guideline doc somewhere ;)

— Reply to this email directly, view it on GitHub https://github.com/jajm/koha-staff-interface-redesign/issues/10#issuecomment-1236764334, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKC5CAZ4VUSI4P3V42CMN3V4W47JANCNFSM55N5CFGQ . You are receiving this because you authored the thread.Message ID: @.***>

black23 commented 2 years ago

From W3 about contrast

jajm commented 1 year ago

I think most contrast issues have been solved by the latest patches. Some remain, but master has contrast issues too. Unless I missed something critical, I consider it is outside the scope of the redesign

mrenvoize commented 1 year ago

I agree.. we're good here for now.

I see 5 outstanding contrast issues on the main page, but all are trivially solvable as their own bug follow-ups and would be better tracked outside of this patchset in my opinion.. lets concentrate on getting this in and fixing further issues as their own thing.

Example, the separators one is a simple fix on .separator color

.separator {
  color: #bfbfbf;
  padding: 0 .2em;
}
mrenvoize commented 1 year ago

Perfect sort of thing for Academy students ;P

mrenvoize commented 1 year ago

Moved to Bug 31760 - Low constrast of some colors (WCAG)