jajm / koha-staff-interface-redesign

Koha fork - only for staff interface redesign (bug 30952)
GNU General Public License v3.0
1 stars 1 forks source link

Browse search has formatting issues #23

Open kfischer opened 2 years ago

kfischer commented 2 years ago

The browse search available on the staff detail pages doesn't fit the new style and needs a bit more work:

grafik

mrenvoize commented 2 years ago

This depends where you are on the browse.. if you're on the first result, in the middle of the resultset or on the last result.. it's nice to have the distinctions to show you can't browser further left or right.. but it does need a little tweak or two to work right in all three cases.

kfischer commented 2 years ago

I meant that the colors, border lines etc. are not correct yet. like the background is a light blue (hope for you too) and not a standard one I think. There also should be no green outline.

mrenvoize commented 2 years ago

I think I was just pointing out that the position in the browse results you are in makes a difference in the current styling applied.. we need to take that into account when fixing the background and borders that are certainly missing here currently.

First result

screenshot-staff-bug30952r sandboxes biblibre eu-2022 09 09-15_58_12

Middle result

screenshot-staff-bug30952r sandboxes biblibre eu-2022 09 09-15_58_27

Last result

screenshot-staff-bug30952r sandboxes biblibre eu-2022 09 09-15_58_41

kfischer commented 2 years ago

This looks much better now.

It still feels a bit different than the new style. One thing is the background color on the top part - I think the blue is not right with the new greys and greens we use.

grafik

jajm commented 2 years ago

image

mrenvoize commented 2 years ago

This all looks great for me.. closable.