search

jajm / koha-staff-interface-redesign

Koha fork - only for staff interface redesign (bug 30952)
GNU General Public License v3.0
1 stars 1 forks source link

System preference <td> on preferences.tt are the same color background as the <body> background #55

Closed ricofreak closed 2 years ago

ricofreak commented 2 years ago

If you search for system preferences the <td>'s have a background color (#f3f4f4) which is exactly the same as the <body> background. I end up losing my place as I cannot see where the <td> ends.

ricofreak commented 2 years ago

This actually effects most tables. It makes the table blend with the body background color. Do we need to add some kind of table border?

mrenvoize commented 2 years ago

Aha, I resolved this elsewhere by ensuring 'content' was inside a 'page-section'.. i.e. it had a white background... this is one I think we should all help with as follow-ups after push.. spread the load.

mrenvoize commented 2 years ago

See issue #45 and issue #22 for some further details around this @ricofreak

mrenvoize commented 2 years ago

Adding the 'page-section' class to the divs with 'prefs-tab' class yields this @ricofreak, does that work for you?

screenshot-pro-mt38042-koha demo biblibre eu-2022 10 03-13_33_20

ricofreak commented 2 years ago

Yes, that looks much better to me! Thanks!

mrenvoize commented 2 years ago

OK.. I'll add that as a bug on bugzilla now.. the screenshot was just a test I did locally.. I'll go ahead and work through the codebase adding page-section divs.

mrenvoize commented 2 years ago

See bug 31758