Patron detail page - Githubissues

jajm / koha-staff-interface-redesign

Koha fork - only for staff interface redesign (bug 30952)

GNU General Public License v3.0

1 stars 1 forks source link

Patron detail page #58

Open tomascohen opened 2 years ago

tomascohen commented 2 years ago

This might be something that happens in other places, but I'm focusing here.

Vertical dark grey box on the left.

[x] Patron information (address, etc) needs some line spacing. Too crowded, feels too stuffed and unreadable. This might already be the case in current Koha, but with the grey background, contrast is lower and makes it worse. I'd probably leave that area out of the dark grey, probably with a surrounding box.
[x] Tabs feel untidy because text is moved to the right when you choose it. Could we kee the texts aligned?

Center area

This area feels generally untidy

[x] Green in the tabs is too dark and font is black. I'd stick to some pastel green combinations and certainly make box lines lighter and thinner.

jajm commented 2 years ago

To make comparisons easier:

Personally I find the new version less crowded, and easier to read. And the contrast ratio is also better according to firefox dev tools

Tabs feel untidy because text is moved to the right when you choose it. Could we kee the texts aligned?

I think this has been fixed by #53

jajm commented 2 years ago

Green in the tabs is too dark [...]. I'd stick to some pastel green combinations and certainly make box lines lighter and thinner.

I'm not particularly good at picking good looking colors :) Can you suggest some ?

and font is black

It sounds like a problem, but I don't see one. Can you explain ?

mrenvoize commented 2 years ago

Not sure I understand the issues with the left sidebar mentioned.. I think it's clearer with the new UI.. spacing is as it was (could be increased, but in my opinion that's another follow-up for later and not directly related).. contrasts seem better to me. Tabs, I'm assuming you still mean in the left sidebar, seem OK too to me.. I don't see a jump to right at all..

Regarding the main content area. I agree I think we've still not completely got to the bottom of the tabbed space at the bottom. I still wonder if 'Pills' inside a 'page-section' might work more consistently than having tabs and a green border.. the inconsistency sticks out to me. (Pills is what the original presentation suggested we would switch to)

mrenvoize commented 2 years ago

The pills stuff is mentioned in issue #17 too for more details