search

jajodiaraghav / Snake

A simple game built using Python Pygame Library
20 stars 26 forks source link

Added blocks to Snake game #14

Closed silversword05 closed 6 years ago

silversword05 commented 6 years ago

Sir, I have made the changes ordered by you

silversword05 commented 6 years ago

Sir, I have made repetitive commits by mistake. Please pardon me. I will not repeat it again. The Snake.py file contains the required changes.

jajodiaraghav commented 6 years ago

I think you either did not understand what I mentioned in the previous PR, or you didn't bother to understand it.

capture

Have a look at your commit messages. Do you think any org will merge your PR with such commit messages? "Sir make changes"? "Sir I have made the changes as you told"? Really?

Open Source is more about learning and developing your skills rather than getting your PRs merged. Learn to use git properly, learn to write proper commit messages, learn to open and claim issues before creating PRs.

Sir, I have made the changes ordered by you

ordered => requested

jajodiaraghav commented 6 years ago

These links might help: https://git-scm.com/book/en/v2/Git-Basics-Undoing-Things https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History https://github.com/zulip/zulip-gci/blob/master/docs/fixing-commits.md

silversword05 commented 6 years ago

I will take care of it next time