search

jajuk-team / jajuk

Advanded jukebox for users with large or scattered music collections
48 stars 19 forks source link

Add an item class for discs #1517

Open bflorat opened 9 years ago

bflorat commented 9 years ago

Reported by itoijala on 9 Jan 2010 14:12 UTC It would be useful to have a (logical) item class for discs (individual (physical) cd's of the album. This would make it possible to sort and filter tracks by disc number more effectively (see #1436). Albums should be able to return a list of associated discs. The Disc class should store the disc number and a reference to the album.

bflorat commented 9 years ago

Commented by itoijala on 9 Jan 2010 15:40 UTC Tracks without a disc number tag should be automatically assigned the disc number 1.

bflorat commented 9 years ago

Commented by bflorat on 10 Jan 2010 16:41 UTC This makes sense to me, to be done in future releases.

On default disc id value : I'm unsure if it's a good idea because null is different from 1 : the value is not given. We may need to differentiate from real "1" value. Dealing null value as 1 can be done in GUI anyway.

bflorat commented 9 years ago

Commented by Sesamstrasse on 10 Jan 2010 17:34 UTC This change has to be done with the album_artist refactor. I really support this change with a disc class because at the moment we have only workarounds for sampler and multi disc albums. Creating a disc class would make things much clearer.

But we need a good concept first, because this is not so easy. A lot of things are affected, a lot of use cases.

bflorat commented 9 years ago

Commented by bflorat on 24 Jan 2011 19:19 UTC Moved to feature, probably too complex for now