search

jajuk-team / jajuk

Advanded jukebox for users with large or scattered music collections
49 stars 19 forks source link

Song Rating bug: Voiding queue makes song stop playing, causes poor rating. #1613

Open bflorat opened 9 years ago

bflorat commented 9 years ago

Reported by mats ahlgren on 7 May 2010 01:05 UTC Deleting a song from the queue (for example with the Broom/VoidTheQueue icon) forces it to stop playing, usually causing an unanticipated loss of rating

bflorat commented 9 years ago

Commented by bflorat on 20 May 2010 22:00 UTC The automatic ratings are only based on the play time, we don't want to make things more complicated and treat separately stops coming from a user action, from jajuk closing, from queue cleanup or whatever. BTW it's the sound engine that update the played time and there, we can't get aware of the origin of the stop from the GUI (separation of concerns).

bflorat commented 9 years ago

Commented by bflorat on 20 May 2010 22:03 UTC I keep this opened as a feature request in the case where in an unforeseeable future, someone would like to provide a patch. I for one advice not to implement it to keep things simple.