search

jajuk-team / jajuk

Advanded jukebox for users with large or scattered music collections
49 stars 19 forks source link

Problem with capital or small letters #1957

Open bflorat opened 9 years ago

bflorat commented 9 years ago

Reported by manfred on 9 Jan 2014 17:38 UTC Jajuk shoud not make Differences between capital or small letters. Many Artists are listed double ore more

bflorat commented 9 years ago

Commented by bflorat on 17 Jan 2014 06:17 UTC Thanks for reporting.

This makes sense. I agree on the fact that we should merge artists on a case insensitive base. We will study this possibility for next release as 1.10 is now in maintenance only state.

We must be careful to migrate user-provided information when possible (like custom properties or ratings) on existing items. Some will be lost due to the merge between different cases items.

Technical evaluation for the team :

It was done this way the case on Jajuk a very long time ago (until release 1.1 in 2005). In 1.0, release was computed this way : String sId = MD5Processor.hash(sName.trim().toLowerCase());

and from 1.1, String sId = MD5Processor.hash(sName);

The change has been done by the following commit apparently not linked to any bug. The same change has been done for all logical items (albums, tracks, genres...) commit f2f2115fc54226c9cd396d323af83337141e63e7 Author: Bertrand Florat bertrand@florat.net 2006-01-28 21:08:21 "Logical items are now all case sensitive"

See also #566, maybe a regression.

gkerdal commented 4 years ago

I try to use MD5Processor.hash(sName.trim().toLowerCase()); locally to see the behaviour on a new fresh collection of 2 albums of the same artist with 2 different cases : let's say Group1 and group1. 1- The collection view shows only one artist, good point. The display name is group1. 2 - Let's say I'm not satisfied by the lower case choice, I'd prefer Goup1. I try to update the property value : I enter and validate "Group1" but then nothing happens. If Jajuk relies on the id, it's not a bug since Id(group1)=Id(Group1) 3 - If I change group1 by group12, then the update of the artist name is processed. I get the expected behaviour

In summary, the default artist name may not be the user's choice so we should provide a way to correct the case easily.