search

jajuk-team / jajuk

Advanded jukebox for users with large or scattered music collections
49 stars 19 forks source link

Cover Dialog behavior when selecting a default cover #1981

Closed bflorat closed 8 years ago

bflorat commented 9 years ago

Reported by Gwen Kerdal gkerdal on 30 Nov 2014 15:04 UTC Hello,

In the select cover view dialog when I click on "Use this cover as the default cover for this album", the dialog window stays open.

I found this behavior not efficient, because I need to close the window to go the next album without cover. As a user, if I chose a default cover, my action on the current dialog is finished, I don't need it any more.

Do you see a reason to keep this dialog open in that case ?

Cheers,

Gwen Kerdal.

bflorat commented 9 years ago

Commented by bflorat on 1 Dec 2014 19:47 UTC I agree, we should close the popup.

Can you do in 1.10.8 ?

bflorat commented 9 years ago

Commented by Gwen Kerdal gkerdal@gmail.com on 1 Dec 2014 20:02 UTC Yes, I'd like to. (Git question :) Should I clone the 1.10.8 branch locally or should I go on with my own branch ?

bflorat commented 9 years ago

Commented by bflorat on 1 Dec 2014 20:26 UTC For now, please just send us a merge request and continue to work on your current branch*. I'll grant you push rights to the official repo when we'll have switch to github.

(*) which branch are you on ? (git status). You should be on the hotfix/release-1_10_8 branch